Repository navigation
fix(updater): a missing historical, performance or distributions worksheet keeps the published fund - #98
Merged
Conversation
…sheet keeps the published fund ISH-1: only the holdings sheet was guarded. A missing or renamed Historical sheet wrote every history page empty and deleted the old ones, a missing Performance sheet published null returns still labelled official, and a missing Distributions sheet emptied the distribution rows. worksheetsProblem() rejects a download whose worksheet is empty where the published meta.json has history rows, official returns or distribution rows: the fund keeps its previous complete state and counts as failed. A fund that never published them passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
worksheetsProblem()rejects such a download when the publishedmeta.jsonhas history rows, official returns (officialReturns.asOfDate) or distribution rows: the fund keeps its previous complete state and counts as failed, like a holdings guard rejection. A fund that never published them (new fund, metal trust without distributions) passesNot in this PR
Checks
bun test: 37 pass, 0 fail; the newpipeline 3test fails on the old code for each worksheet separately (Historical, Performance, Distributions)bun build --target=bun scripts/update-data.ts --outfile=/dev/null,bun build --target=bun src/main.tsx --outfile=/dev/null.claude/tools/etfs/tc/check.sh: same 53 lines as main (pre-existing ide-mode baseline), no new errorscheck-readme.ts: ok;git diff --check: cleanapi/restored