Repository navigation
feat(updater): closed funds skip fetch and guard, guard rejection is failed, test groups of at most five - #96
Merged
Conversation
…failed, test groups of at most five - open-items etfs Q1: CLOSED_FUNDS (empty; UAE and BILT still trade) with the shared closedFund, withoutClosedFunds and markClosedFunds; a closed fund is never fetched, guarded, reported or pruned, and TICKERS accepts it while its row is published - open-items etfs Q2: already compliant (guard rejection is failed, a new fund that is rejected or never answered gets a catalog-only row); the pipeline test now proves it - open-items etfs Q12: test groups split to at most five tests each
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
apply-holdings-guard.ts(addsClosedFund,closedFund,markClosedFunds,withoutClosedFunds)CLOSED_FUNDS(empty - the candidates UAE and BILT still trade, no liquidation 497 on SEC and both fund pages are live). Inmain():withoutClosedFundswrapscatalogEligible(after the catalog and TICKERS filters, beforeselectUpdateBatchspends MAX_FETCHES and before any request)markClosedFundswraps the index rows right beforeindex.jsonis builtupdateFund, so it is reportedfailed(fund line, summary tally,RunSummary.failed); a new fund without a result falls back tobuildCatalogRow(dataFile null, full metrics keys with returnsBasis). The pipeline testa fund never fetched successfully ...now also covers a new fund whose holdings the guard rejects and a following good run that publishes both catalog-only funds in fullcontrols 8 -> 4+4,parsing 6 -> 3+3,pipeline 13 -> 5+4+4)Why
open-items etfs Q1, Q2, Q12: one policy for closed funds and guard failures in all 29 brands, same shape as daggerok/Schwab#73
Checks run
bun test: 36 pass, 0 fail, 301 expect() calls (35/274 before the change; the split kept 36/301)a closed fund is never fetched or reported failed ...fails when any of the four wiring points is reverted (withoutClosedFunds, markClosedFunds, TICKERS check, pruning exemption)bun testwith the workflow env,bun buildof the updater andsrc/main.tsx,git diff --check, hub check-scripts/workflow/readme/pages, exec bit,tc/check.shadds no IDE errors vs origin/mainTICKERS=IBTQ REQUEST_SLEEP=0 bun scripts/update-data.ts: 1 unchanged, 0 failed. Same run with IBTQ temporarily in CLOSED_FUNDS:[ closed ] IBTQ, 0 failed, index.json diff only the closed marks plus generatedAt. No data committed