fix: respect segmented scalar index flag#49
Merged
Conversation
everySympathy
force-pushed
the
segmented-flag-opt-out
branch
from
ae3a968 to
f5447e4
Compare
everySympathy
force-pushed
the
segmented-flag-opt-out
branch
from
f5447e4 to
1654d3d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a routing bug introduced in #28.
In that PR, we changed
BTREEandINVERTEDto use Lance's segmented index workflow by default. That was too aggressive: it meant callers who explicitly passedsegmented=Falsewould still get the segmented workflow.That makes the flag misleading, and the behavior should be corrected.
After this change:
segmented=Trueuses the segmented index workflowsegmented=Falseuses the existing partitioned workflow, or Lance's direct scalar index path for unsupported distributed typesI also updated the docs and adjusted the regression test to cover this.
Tests
ruff check