Skip to content

Fix css_unban / css_unmute silently failing on SQLite (long -> int via dynamic binder) #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
playaopindo-dev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix css_unban / css_unmute silently failing on SQLite (long -> int via dynamic binder) #285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions CS2-SimpleAdmin/Managers/BanManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,7 @@ public async Task UnbanPlayer(string playerPattern, string adminSteamId, string

foreach (var ban in bansList)
{
int banId = ban.id;
int banId = Convert.ToInt32((object)ban.id);

var sqlInsertUnban = databaseProvider.GetInsertUnbanQuery(reason != null);
var unbanId = await connection.ExecuteScalarAsync<int>(sqlInsertUnban, new { banId, adminId, reason });
Expand All @@ -340,7 +340,10 @@ public async Task UnbanPlayer(string playerPattern, string adminSteamId, string
await connection.ExecuteAsync(sqlUpdateBan, new { unbanId, banId });
}
}
catch { }
catch (Exception ex)
{
CS2_SimpleAdmin.Instance?.Logger?.LogError(ex, "UnbanPlayer failed for pattern {Pattern}", playerPattern);
}
}

// public async Task CheckOnlinePlayers(List<(string? IpAddress, ulong SteamID, int? UserId, int Slot)> players)
Expand Down
2 changes: 1 addition & 1 deletion CS2-SimpleAdmin/Managers/MuteManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ public async Task UnmutePlayer(string playerPattern, string adminSteamId, string

foreach (var mute in mutesList)
{
int muteId = mute.id;
int muteId = Convert.ToInt32((object)mute.id);

int? unmuteId =
await connection.ExecuteScalarAsync<int>(sqlInsertUnmute, new { muteId, adminId, reason });
Expand Down