Skip to content

Smalloc#253

Open
mjp41 wants to merge 4 commits into
daanx:masterfrom
mjp41:smalloc
Open

Smalloc#253
mjp41 wants to merge 4 commits into
daanx:masterfrom
mjp41:smalloc

Conversation

@mjp41

@mjp41 mjp41 commented Jan 26, 2026

Copy link
Copy Markdown
Collaborator

Addresses #248. This is based on @zooko's personal fork.

@zooko zooko left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read over this patch and it looks correct to me.

@zooko zooko left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read over this patch and it looks correct to me. :-) (That was easy.)

@zooko zooko left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

Comment thread build-bench-env.sh

if test "$setup_s" = "1"; then
checkout s $version_s https://github.com/zooko/smalloc
cargo build --release --package smalloc-ffi

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to add cargo as a dependency in the install packages phase.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I realised that, but I was nudging github from my phone. I'll fix today.

@zooko

zooko commented May 21, 2026

Copy link
Copy Markdown

Hey there! Is there anything I can do to help get smalloc merged into main here? Thanks.

@mjp41

mjp41 commented May 21, 2026

Copy link
Copy Markdown
Collaborator Author

@copilot resolve the merge conflicts in this pull request

@mjp41

mjp41 commented May 21, 2026

Copy link
Copy Markdown
Collaborator Author

Hey there! Is there anything I can do to help get smalloc merged into main here? Thanks.

Sorry, I can't remember what the blocker was. I'll update the branch and see if there is anything we need from you.

@zooko

zooko commented May 26, 2026

Copy link
Copy Markdown

No prob. Looking forward to the results! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants