compiler: reject non-finite opacity values - #2840
Merged
Merged
Conversation
Signed-off-by: Alexander Wang <alex@terrastruct.com>
alixander
force-pushed
the
agent/fix-nonfinite-opacity
branch
from
August 10, 2026 01:35
b845478 to
0964ad0
Compare
alixander
marked this pull request as ready for review
August 10, 2026 01:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
style.opacityvalues at the existing style validation boundaryNaN, signedInf/Infinity, and valid 0, 0.5, and 1 controlsWhy
strconv.ParseFloatacceptsNaN. The existing range check used onlyf < 0 || f > 1, and both comparisons are false for NaN. That allowed NaN into the exported target graph, where JSON marshaling failed later withjson: unsupported value: NaNinstead of reporting the invalid source value.The validation now explicitly rejects NaN and infinities before storing the opacity.
User impact
Invalid opacity values now fail at their D2 source location with the normal opacity diagnostic. Valid opacity values render exactly as before.
Validation
go test ./d2graph ./d2compiler -count=1go test -race ./d2compiler -run '^TestOpacityValidation$' -count=1go vet ./d2graph ./d2compilergo test ./e2etests -run '^TestE2E$' -count=1git diff --check