Skip to content

Implement .cleanup-ignore support in cleanup.yml workflow#425

Merged
d-oit merged 1 commit into
mainfrom
fix/cleanup-ignore-support-12929004119878635715
Jun 7, 2026
Merged

Implement .cleanup-ignore support in cleanup.yml workflow#425
d-oit merged 1 commit into
mainfrom
fix/cleanup-ignore-support-12929004119878635715

Conversation

@d-oit
Copy link
Copy Markdown
Owner

@d-oit d-oit commented Jun 7, 2026

This change implements full support for the .cleanup-ignore file within the .github/workflows/cleanup.yml workflow.

Previously, the workflow only had hardcoded exceptions and ignored the .cleanup-ignore file mentioned in its PR body template. The updated logic:

  1. Reads .cleanup-ignore at the start of the detection step.
  2. Gracefully handles comments (#) and empty lines.
  3. Excludes any script if its basename or relative path matches an entry in the ignore file.
  4. Tracks and reports the number of skipped files in the GitHub Action step summary.

This fix ensures that scripts like scripts/pre-commit-hook.sh (which are currently listed in .cleanup-ignore) are no longer incorrectly flagged for deletion.

Fixes #424


PR created automatically by Jules for task 12929004119878635715 started by @d-oit

- Add logic to parse .cleanup-ignore in Detect unused scripts step
- Skip ignored files (by basename or path) during unused script detection
- Report skipped file count to GITHUB_STEP_SUMMARY
- Close PR #422 as it was incorrectly flagging ignored files

Co-authored-by: d-oit <6849456+d-oit@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
do-web-doc-resolover Ready Ready Preview, Comment Jun 7, 2026 8:16am

@deepsource-io
Copy link
Copy Markdown

deepsource-io Bot commented Jun 7, 2026

DeepSource Code Review

We reviewed changes in 3fd6c20...dfb2eba on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
JavaScript Jun 7, 2026 8:15a.m. Review ↗
Python Jun 7, 2026 8:15a.m. Review ↗
Rust Jun 7, 2026 8:15a.m. Review ↗
Shell Jun 7, 2026 8:15a.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@codacy-production
Copy link
Copy Markdown
Contributor

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@d-oit d-oit enabled auto-merge (squash) June 7, 2026 08:18
@d-oit d-oit merged commit efee277 into main Jun 7, 2026
38 of 39 checks passed
@d-oit d-oit deleted the fix/cleanup-ignore-support-12929004119878635715 branch June 7, 2026 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: Implement .cleanup-ignore support in cleanup.yml workflow

1 participant