Skip to content

fix(tests): stabilize flaky command palette E2E test #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
d-oit merged 1 commit into from
Jun 5, 2026
Merged

fix(tests): stabilize flaky command palette E2E test #273

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions tests/e2e/modern-shell.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,19 +13,21 @@ test.describe('Modern Shell UX', () => {
// Toggle on
await page.keyboard.press('Control+k');
await expect(palette).toBeVisible();
// Wait for input focus (palette uses setTimeout 10ms to focus input)
await expect(page.locator('.command-palette-header input')).toBeFocused({ timeout: 3000 });

// Toggle off with Escape
await page.keyboard.press('Escape');
await expect(palette).not.toBeVisible();
await expect(palette).not.toBeVisible({ timeout: 5000 });

// Toggle on again
await page.keyboard.press('Control+k');
await expect(palette).toBeVisible();
await expect(page.locator('.command-palette-header input')).toBeFocused({ timeout: 3000 });

// Toggle off by clicking overlay
// Use dispatchEvent for more reliable overlay clicks across viewports
await page.locator('.command-palette-overlay').evaluate(el => (el as HTMLElement).click());
await expect(palette).not.toBeVisible();
await expect(palette).not.toBeVisible({ timeout: 5000 });
});

test('searching and keyboard navigation in palette', async ({ page }) => {
Expand Down
Loading