fix: resolve E2E test failures — nested transaction + tiptap timing#271
Merged
Conversation
- db-worker.ts: defensive COMMIT before BEGIN TRANSACTION to handle SQLite WASM quirk where INSERT...RETURNING leaves autocommit off - library.spec.ts, features.spec.ts: wait for ProseMirror contenteditable=true instead of tiptap-content visibility to ensure useEditor hook has resolved before clicking Save Fixes all 4 previously failing E2E tests. Co-authored-by: d-oit <6849456+d-oit@users.noreply.github.com>
 |
|
Overall Grade |
Security  Reliability  Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| JavaScript |  |
Jun 5, 2026 3:18p.m. | Review ↗ |
| Python |  |
Jun 5, 2026 3:18p.m. | Review ↗ |
| Shell | |
Jun 5, 2026 3:18p.m. | Review ↗ |
| SQL | |
Jun 5, 2026 3:18p.m. | Review ↗ |
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
Contributor
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 2 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 4 previously failing E2E tests.
Changes
COMMITbeforeBEGIN TRANSACTIONwith narrowed catch clause. Fixes SQLite WASM quirk whereINSERT...RETURNINGwithreturnValue:"resultRows"leaves autocommit off..ProseMirror[contenteditable="true"]instead of.tiptap-contentvisibility. EnsuresuseEditorhook has resolved before clicking Save.Validation
Co-authored-by: d-oit 6849456+d-oit@users.noreply.github.com