chore(observability): adopt traceId on critical UI actions + harden CI workflows#456
Merged
Conversation
Convert raw console.* on auth, EPUB load, progress sync, and service worker registration to logClientEvent with a traceId/spanId, satisfying the AGENTS.md TIER 1 rule 'emit traceId on every critical UI action'. Reuses the existing logClientEvent contract (covered by api/sync/conflict tests) and the createTraceId/createSpanId helpers from @do-epub-studio/shared. Files: ReaderPage.tsx (annotations fetch, logout), useReaderEpub.ts (EPUB init, progress load/save), main.tsx (service-worker registration, background sync). Ref: plans/066-goap-comprehensive-analysis-2026-06-05.md
Plans 066 (analysis) and 067 (ADR) document the two evidence-backed gaps surfaced by the latest comprehensive survey: CI tooling exec-bit fragility and partial client observability. Companion to the fixes in the prior two commits. ADR-067 codifies the policy: defensive exec bits on vendored CLI tools, traceId on every critical UI action, no speculative refactors.
Deploying do-epub-studio with
|
| Latest commit: |
267748d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://945c189e.do-epub-studio.pages.dev |
| Branch Preview URL: | https://feat-goap-068-swarm-open-iss.do-epub-studio.pages.dev |
Contributor
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 7 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
🚀 Performance Report⚡ Startup & Interaction
🛠️ CI & Workflow
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 0 of GOAP plan 068. Closes issues #439, #441.
ci(workflows): guarantee exec bit on actionlint/zizmor (CI failure on main: 27003766438 #439)
Fixes the intermittent Permission denied failure on main (root cause: pip/curl installs into ~/.local/bin drop the exec bit). The validate-workflows.sh now re-chmods the resolved binary before each use.
feat(web): adopt traceId on critical UI failure paths (CI failure on main: 27051074721 #441)
Raw console.* on auth, EPUB load, progress sync, and service-worker registration now go through logClientEvent with a traceId/spanId, satisfying the AGENTS.md TIER 1 'emit traceId on every critical UI action' rule. Reuses the existing logClientEvent contract.
docs(plans): add plans 066, 067, 068 — comprehensive analysis, observability/CI ADR, and the swarm plan to close all open issues.
All changes verified by the full quality gate (lint + typecheck + 290 reader-core tests + 264 web tests + build + e2e smoke).