Let the differ demo run alongside sibling-repo demos#401
Merged
Conversation
JonJagger
commented
Jun 11, 2026
Member
Until now `make demo` and `make run-tests` brought the client/server up on
fixed container names and fixed host ports, and the cleanup step ran a
global `docker rm --force $(docker ps -aq)` that destroyed EVERY container
on the machine - including any sibling repo's running demo (eg web). So a
differ demo or test run could not coexist with another repo's demo: they
fought over host ports and nuked each other. This mirrors the equivalent
web (#358), creator and dashboard changes for differ.
- Each demo/test run is its own docker-compose project (COMPOSE_PROJECT_NAME,
default differ), so container names are namespaced per project.
- Publish no host ports at all. The demo execs into the client container
and the client reaches the server over the project's private network
(by the `server` service name), so nothing needs a host port and
nothing collides.
- Replace containers_down's global `docker rm --force` nuke with a
project-scoped `docker compose down`, so tearing down differ no longer
kills the other repos' demos.
The demo/test helpers no longer assume fixed container names; they resolve
a container by compose project+service label via a shared service_container()
in lib.sh.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ToreMerkely
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.