Repository navigation
fix(readers): apply two's complement when load_waveform(signed=True) - #27
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
load_waveform(signed=True)set thesignedflag but never applied the two's-complement conversion, so the raw unsigned bit patterns were only labelled as signed. The readers now build theWaveformas unsigned and callas_signed()whensigned=True, so the result matchesload_waveform(...).as_signed(). The change is in the shared_value_change_to_waveforminreaders/base.py, so it applies to all readers.Reported in #26.
Tests
test_vcd_load_waveform_signed_values, which comparessigned=Trueagainst.as_signed()on a 4-bit counter. It fails without the fix.