Add return types and update PHPDoc bool types#252
Closed
RobinvanderVliet wants to merge 3 commits into
Closed
Conversation
- Add return types to all functions. - Change "boolean" to "bool" in PHPDoc for consistency, instead of using both mixed.
Owner
The unit test could be adjusted. I'm wary because adding return types to methods will be a breaking change - classes extending JsonMapper will not have those return types in their overridden methods, and PHP will complain about that:
So this would require a new major version (6). In that case the unit test needs to be adjusted, so that we have proper return types for all methods. |
Owner
|
@RobinvanderVliet please rebase against master. |
cweiske
added a commit
that referenced
this pull request
May 20, 2026
BC break if you extend JsonMapper. Related: #252
cweiske
added a commit
that referenced
this pull request
May 20, 2026
I don't want to enforce the logger to be a \Psr\Log\LoggerInterface, both to keep BC and to allow light-weight software that does not depend on the PSR interface classes. BC break if you extend JsonMapper. Related: #252
Owner
|
I've implemented the changes myself now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.