Conversation
|
coverage: 93.355% (+0.006%) from 93.349% — pablopupo:fix/2024-make-ties-string-voice into cuthbertLab:master |
mscuthbert
requested changes
Sep 14, 2026
mscuthbert
left a comment
mscuthbert
left a comment
Member
There was a problem hiding this comment.
It's rather unclear that this behavior is what should be expected -- we have two measures with one voice each with no time signature. I would not guarantee that the second measure would get a rest of 1 QL in there. The test does not cover makeTies. This needs a human touch -- will not be approved w/o human interaction.
| secondMeasure = stream.Measure([stream.Voice(id='1')]) | ||
| part.append([firstMeasure, secondMeasure]) | ||
|
|
||
| part.makeRests(fillGaps=True, inPlace=True) |
Member
There was a problem hiding this comment.
how is this testing makeTies? I see just makeRests here? Test what is claimed to be testing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2024.
makeTiesnow resolves string and integer voice IDs throughgetElementById()and falls back to the next measure when no matching voice exists.I used explicit
Nonechecks rather than the chainedorsuggested in the issue because an emptyVoiceis falsey; the chained form would skip a valid empty matching voice.AI-assisted (Codex). I reviewed and tested the final change.