Skip to content

chore: minor adjustments on or8n documentation#41

Open
maxigimenez wants to merge 4 commits into
mainfrom
maxi/eng-482-final-documentation-check
Open

chore: minor adjustments on or8n documentation#41
maxigimenez wants to merge 4 commits into
mainfrom
maxi/eng-482-final-documentation-check

Conversation

@maxigimenez
Copy link
Copy Markdown
Contributor

@maxigimenez maxigimenez commented May 22, 2026

Summary

Tweak orchestration documentation for clarity and accuracy following the pwc-p v2 release (discover + run subcommands). Eliminates redundant documentation, clarifies when discovery is optional, and ensures consistent messaging across all guides.

Summary by CodeRabbit

Documentation

  • Improved Playwright orchestration guides with clearer two-step workflow documentation (discover → run)
  • Enhanced troubleshooting guide with better debug mode clarification and examples
  • Updated command patterns and examples across reporter documentation for consistency
  • Refined setup instructions and formatting throughout for improved clarity

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 22, 2026

Warning

Rate limit exceeded

@maxigimenez has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 31 minutes and 54 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: fee55175-a5ae-4e28-be54-1c5a26f1b8b0

📥 Commits

Reviewing files that changed from the base of the PR and between cc0dcac and 1fbfda8.

📒 Files selected for processing (3)
  • getting-started/ci-setup/nx.md
  • guides/ci-optimization/playwright-orchestration.md
  • guides/troubleshooting-playwright.md
📝 Walkthrough

Walkthrough

Documentation refactor consolidating pwc-p discoverpwc-p run orchestration workflow guidance across multiple CI setup guides, reference pages, and troubleshooting documentation. Updates restructure content into clearer sections for full-suite and filtered test patterns, add discovery-file workflow examples, and clarify reporter configuration.

Changes

Orchestration Workflow Documentation

Layer / File(s) Summary
Orchestration workflow structure and setup
guides/ci-optimization/playwright-orchestration.md
Core CI guide restructured with explicit bullet sections for pwc-p discover vs pwc-p run, discovery filtering options (grep, tags, last-failed), and updated reporter configuration guidance. Setup section now shows clear two-step command flow with formatted npx pwc-p discover / npx pwc-p run examples.
Reference documentation consolidation
resources/reporters/currents-playwright/pwc-p.md, resources/reporters/currents-playwright/README.md
pwc-p.md refined with unified subcommand list and environment-variable workflow for CURRENTS_DISCOVERY_FILE. README.md updated with separate "Full suite" and "Filtered tests" command patterns clarifying when discovery is optional vs required and flag placement for Playwright filters.
Nx orchestration integration example
getting-started/ci-setup/nx.md
Nx example adds or8n-discover target running npx pwc-p discover to generate tests.txt and updates or8n target to use --pwc-discovery-file tests.txt. Local execution example demonstrates filtered discovery with --grep followed by orchestration run using shared CURRENTS_CI_BUILD_ID.
Debug mode clarification and troubleshooting formatting
guides/troubleshooting-playwright.md
"Activate Debug Mode" section restructured into GitBook tabs with pwc and pwc-p command examples. Added explicit explanation of --pwc-debug behavior (remote vs full modes) and clarified that debug logs are uploaded to Currents with confirmation message after completion.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

  • currents-dev/currents-readme#35: Documents the orchestration v2 pattern (pwc-p discoverpwc-p run via --pwc-discovery-file) that this PR reinforces across multiple guides.
  • currents-dev/currents-readme#39: Introduced the split reference structure (pwc-p.md, pwc-p-discover.md, pwc-p-run.md) that this PR consolidates and clarifies through improved workflow documentation.
  • currents-dev/currents-readme#33: Earlier refactor of the main orchestration guide that this PR extends with clearer discovery filtering, reporters configuration, and two-step setup procedures.

Suggested reviewers

  • miguelangaranocurrents
  • twk3
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the primary focus of the changeset—documentation adjustments related to orchestration (or8n) following the pwc-p v2 release, though it understates the scope of changes across multiple files and conceptual improvements.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch maxi/eng-482-final-documentation-check

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@maxigimenez maxigimenez marked this pull request as ready for review May 22, 2026 10:53
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
guides/troubleshooting-playwright.md (1)

88-106: ⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Add language specifier to environment variable code block.

The code block in the "Environment variable" tab is missing a language identifier. Adding bash will enable proper syntax highlighting for the shell commands.

🔧 Proposed fix
-```
+```bash
 # on Linux
 CURRENTS_PROJECT_ID=PROJECT_ID \ // the projectId from https://app.currents.dev
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@guides/troubleshooting-playwright.md` around lines 88 - 106, The fenced code
block containing the environment variable examples for Linux and Windows lacks a
language specifier, so add ```bash (or ```sh) as the opening fence before the
Linux block and the Windows block where appropriate to enable shell syntax
highlighting; update the existing triple-backtick fences that wrap the
CURRENTS_* examples (the block starting with "on Linux" and the block starting
with "on Windows") to use ```bash so the shell commands render correctly.
🧹 Nitpick comments (1)
guides/troubleshooting-playwright.md (1)

8-8: 💤 Low value

Optional: Remove unnecessary HTML entity.

The   HTML entity at the end of this line represents a non-breaking space, which is typically unnecessary at the end of a sentence in markdown. A regular space or no trailing space would be cleaner and more maintainable.

✨ Proposed simplification
-If you are experiencing issues with using `@currents/playwright`, enable debug mode to collect more information about the failure and submit a support request via our support channels.&`#x20`;
+If you are experiencing issues with using `@currents/playwright`, enable debug mode to collect more information about the failure and submit a support request via our support channels.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@guides/troubleshooting-playwright.md` at line 8, Remove the unnecessary HTML
entity "&`#x20`;" at the end of the sentence in the
guides/troubleshooting-playwright.md line that mentions enabling debug mode for
`@currents/playwright`; edit the sentence so it ends with a normal period (or a
regular trailing space if needed) instead of the non-breaking-space entity to
keep the markdown clean and maintainable.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@getting-started/ci-setup/nx.md`:
- Line 103: The nx:run-commands entries in getting-started/ci-setup/nx.md
currently use an invalid options.config; remove the options.config keys and
instead add cwd: "apps/e2e-03" to the same run target so Playwright will find
apps/e2e-03/playwright.config.ts, and ensure any invocation of pwc-p does not
try to pass Playwright’s --config flag (use pwc-p’s documented --pwc-config if
needed); update the run command blocks that reference options.config and replace
with cwd plus the correct flag usage for pwc-p.

In `@guides/ci-optimization/playwright-orchestration.md`:
- Line 107: Replace the problematic sentence "Creates a discover file at a
destination, the use the file as an input for `pwc-p run` command" with
corrected wording: use "Creates a discovery file at a destination, then use the
file as an input for `pwc-p run` command" (change "discover" to "discovery" and
"the" to "then") so the documentation sentence reads correctly.
- Around line 216-218: The fenced code block containing the command "pwc-p run
-- [...playwright-cli-params]" lacks a language identifier for syntax
highlighting; update the Markdown fenced block by adding a language tag (e.g.,
add "bash" after the opening backticks) so the block becomes a bash code fence
and retains the same command content.

In `@guides/troubleshooting-playwright.md`:
- Around line 72-74: Update the markdown code fences for the pwc and pwc-p
examples so they include a shell language specifier: change the plain
triple-backtick blocks around the "npx pwc --pwc-debug=full ..." and "npx pwc-p
--pwc-debug=full ..." snippets to use ```bash (or ```shell) to enable syntax
highlighting; apply the same change to the other occurrences referenced (lines
~80-82) in guides/troubleshooting-playwright.md.

---

Outside diff comments:
In `@guides/troubleshooting-playwright.md`:
- Around line 88-106: The fenced code block containing the environment variable
examples for Linux and Windows lacks a language specifier, so add ```bash (or
```sh) as the opening fence before the Linux block and the Windows block where
appropriate to enable shell syntax highlighting; update the existing
triple-backtick fences that wrap the CURRENTS_* examples (the block starting
with "on Linux" and the block starting with "on Windows") to use ```bash so the
shell commands render correctly.

---

Nitpick comments:
In `@guides/troubleshooting-playwright.md`:
- Line 8: Remove the unnecessary HTML entity "&`#x20`;" at the end of the sentence
in the guides/troubleshooting-playwright.md line that mentions enabling debug
mode for `@currents/playwright`; edit the sentence so it ends with a normal period
(or a regular trailing space if needed) instead of the non-breaking-space entity
to keep the markdown clean and maintainable.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6b8a8bf3-d1fe-46fe-944f-ecda190ed519

📥 Commits

Reviewing files that changed from the base of the PR and between 6f9eeeb and cc0dcac.

📒 Files selected for processing (6)
  • getting-started/ci-setup/nx.md
  • guides/ci-optimization/playwright-orchestration.md
  • guides/troubleshooting-playwright.md
  • resources/reporters/currents-playwright/README.md
  • resources/reporters/currents-playwright/pwc-p-orchestration.md
  • resources/reporters/currents-playwright/pwc-p.md
💤 Files with no reviewable changes (1)
  • resources/reporters/currents-playwright/pwc-p-orchestration.md

Comment thread getting-started/ci-setup/nx.md Outdated
Comment thread guides/ci-optimization/playwright-orchestration.md Outdated
Comment thread guides/ci-optimization/playwright-orchestration.md Outdated
Comment thread guides/troubleshooting-playwright.md Outdated
@maxigimenez
Copy link
Copy Markdown
Contributor Author

@coderabbitai review the PR

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 22, 2026

@maxigimenez Sure! I'll review the PR now.

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant