Skip to content

feat(qwen3.5+trainer): MTP training loss plumbing aligned with #46229#1

Open
curnane-lab wants to merge 5 commits into
pr-46229from
feature/qwen35-mtp-support-v2
Open

feat(qwen3.5+trainer): MTP training loss plumbing aligned with #46229#1
curnane-lab wants to merge 5 commits into
pr-46229from
feature/qwen35-mtp-support-v2

Conversation

@curnane-lab
Copy link
Copy Markdown
Owner

Wire up Multi-Token Prediction (MTP) training for Qwen3.5 by reusing the inference-side MtpLayer from huggingface#46229 instead of the inline MTP definition from huggingface#45638, and add the matching Trainer hook that combines the auxiliary loss.

Model side (Qwen3.5):

  • CausalLMOutputWithPast gains an mtp_loss field carrying the unweighted MTP loss (averaged over MTP layers and non-ignored tokens).
  • Qwen3_5TextConfig exposes num_nextn_predict_layers (canonical MTP layer count, aligned with [generate] Add proper MTP support huggingface/transformers#46229) and output_mtp_loss (training-only switch).
  • Qwen3_5ForCausalLM dynamically instantiates MtpLayer copies that mirror the main decoder layer architecture (full / linear attention mix, RMSNorm variant) and recomputes the per-layer loss with properly sliced inputs, position embeddings, and labels.

Trainer side:

  • TrainingArguments gains mtp_loss_coef (default 0.0, BC-safe).
  • Trainer.compute_loss adds the unweighted output.mtp_loss * mtp_loss_coef to the main loss at the very end, leaving the model forward signature clean and the combination policy centralized in the trainer.

Supersedes huggingface#45638's inline-MTP approach in favor of a single shared MtpLayer implementation that the inference path already uses.

Refs: huggingface#46229, huggingface#45638

What does this PR do?

Fixes # (issue)

Code Agent Policy

The Transformers repo is currently being overwhelmed by a large number of PRs and issue comments written by
code agents. We are currently bottlenecked by our ability to review and respond to them. As a result,
we ask that new users do not submit pure code agent PRs at this time.
You may use code agents in drafting or to help you diagnose issues. We'd also ask autonomous "OpenClaw"-like agents
not to open any PRs or issues for the moment.

PRs that appear to be fully agent-written will probably be closed without review, and we may block users who do this
repeatedly or maliciously.

This is a rapidly-evolving situation that's causing significant shockwaves in the open-source community. As a result,
this policy is likely to be updated regularly in the near future. For more information, please read CONTRIBUTING.md.

  • I confirm that this is not a pure code agent PR.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

…gface#46229

Wire up Multi-Token Prediction (MTP) training for Qwen3.5 by reusing the
inference-side MtpLayer from huggingface#46229 instead of the inline MTP definition from
huggingface#45638, and add the matching Trainer hook that combines the auxiliary loss.

Model side (Qwen3.5):
* CausalLMOutputWithPast gains an mtp_loss field carrying the unweighted MTP
  loss (averaged over MTP layers and non-ignored tokens).
* Qwen3_5TextConfig exposes num_nextn_predict_layers (canonical MTP layer count,
  aligned with huggingface#46229) and output_mtp_loss (training-only switch).
* Qwen3_5ForCausalLM dynamically instantiates MtpLayer copies that mirror the
  main decoder layer architecture (full / linear attention mix, RMSNorm
  variant) and recomputes the per-layer loss with properly sliced inputs,
  position embeddings, and labels.

Trainer side:
* TrainingArguments gains mtp_loss_coef (default 0.0, BC-safe).
* Trainer.compute_loss adds the unweighted output.mtp_loss * mtp_loss_coef to
  the main loss at the very end, leaving the model forward signature clean
  and the combination policy centralized in the trainer.

Supersedes huggingface#45638's inline-MTP approach in favor of a single shared MtpLayer
implementation that the inference path already uses.

Refs: huggingface#46229, huggingface#45638
@curnane-lab curnane-lab force-pushed the feature/qwen35-mtp-support-v2 branch from b73a820 to 809ef6e Compare June 5, 2026 09:43
- Remove unused imports (is_causal_conv1d_available, is_flash_linear_attention_available)
  from configuration_qwen3_5.py
- Move _init_mtp_layers and _compute_mtp_loss after forward() in both
  modular_qwen3_5.py and modeling_qwen3_5.py to match modular generator output
- Remove extra blank lines inside __init__ to match generated code style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants