feat(qwen3.5+trainer): MTP training loss plumbing aligned with #46229#1
Open
curnane-lab wants to merge 5 commits into
Open
feat(qwen3.5+trainer): MTP training loss plumbing aligned with #46229#1curnane-lab wants to merge 5 commits into
curnane-lab wants to merge 5 commits into
Conversation
…gface#46229 Wire up Multi-Token Prediction (MTP) training for Qwen3.5 by reusing the inference-side MtpLayer from huggingface#46229 instead of the inline MTP definition from huggingface#45638, and add the matching Trainer hook that combines the auxiliary loss. Model side (Qwen3.5): * CausalLMOutputWithPast gains an mtp_loss field carrying the unweighted MTP loss (averaged over MTP layers and non-ignored tokens). * Qwen3_5TextConfig exposes num_nextn_predict_layers (canonical MTP layer count, aligned with huggingface#46229) and output_mtp_loss (training-only switch). * Qwen3_5ForCausalLM dynamically instantiates MtpLayer copies that mirror the main decoder layer architecture (full / linear attention mix, RMSNorm variant) and recomputes the per-layer loss with properly sliced inputs, position embeddings, and labels. Trainer side: * TrainingArguments gains mtp_loss_coef (default 0.0, BC-safe). * Trainer.compute_loss adds the unweighted output.mtp_loss * mtp_loss_coef to the main loss at the very end, leaving the model forward signature clean and the combination policy centralized in the trainer. Supersedes huggingface#45638's inline-MTP approach in favor of a single shared MtpLayer implementation that the inference path already uses. Refs: huggingface#46229, huggingface#45638
b73a820 to
809ef6e
Compare
- Remove unused imports (is_causal_conv1d_available, is_flash_linear_attention_available) from configuration_qwen3_5.py - Move _init_mtp_layers and _compute_mtp_loss after forward() in both modular_qwen3_5.py and modeling_qwen3_5.py to match modular generator output - Remove extra blank lines inside __init__ to match generated code style
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wire up Multi-Token Prediction (MTP) training for Qwen3.5 by reusing the inference-side MtpLayer from huggingface#46229 instead of the inline MTP definition from huggingface#45638, and add the matching Trainer hook that combines the auxiliary loss.
Model side (Qwen3.5):
Trainer side:
Supersedes huggingface#45638's inline-MTP approach in favor of a single shared MtpLayer implementation that the inference path already uses.
Refs: huggingface#46229, huggingface#45638
What does this PR do?
Fixes # (issue)
Code Agent Policy
The Transformers repo is currently being overwhelmed by a large number of PRs and issue comments written by
code agents. We are currently bottlenecked by our ability to review and respond to them. As a result,
we ask that new users do not submit pure code agent PRs at this time.
You may use code agents in drafting or to help you diagnose issues. We'd also ask autonomous "OpenClaw"-like agents
not to open any PRs or issues for the moment.
PRs that appear to be fully agent-written will probably be closed without review, and we may block users who do this
repeatedly or maliciously.
This is a rapidly-evolving situation that's causing significant shockwaves in the open-source community. As a result,
this policy is likely to be updated regularly in the near future. For more information, please read
CONTRIBUTING.md.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.