chore: Java 25 compile+runtime baseline, CI matrix 25/26 (plan-01 A1) - #55
Conversation
Post-merge amendment A1 to Plan 01: drop the "compile at 21, run at 25" split in favour of compiling AND running on Java 25 (the LTS). Java 21 is not a target for this project. - pom.xml: maven.compiler.release and compiler-plugin <release> 21 -> 25 - .github/project.yml: java-versions ["21","25"] -> ["25","26"]; primary 21 -> 25 (add "27" at its GA, ~Sept 2026) - ADR-0001 rewritten (accepted, supersedes the proposed compile-low/run-high form) - Plan 01 gains a Post-Merge Amendments section recording A1 - CLAUDE.md project overview + language-features line updated to Java 25 Verified: reactor compiles clean at --release 25 (bytecode major 69) on a JDK 26 toolchain; the JDK-26 matrix leg is a forward-compatibility guard. Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Sorry @cuioss-oliver, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
|
Warning Review limit reached
Next review available in: 48 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository: cuioss/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe project now compiles and runs on Java 25, tests Java 25 and 26, and documents the accepted baseline across its ADR, implementation plan, and development guidance. ChangesJava 25 compile and runtime baseline
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request updates the project's compile and runtime baseline to Java 25, aligning the build configuration, CI matrix, and documentation (including ADR-0001 and Plan 01 amendments) to target Java 25 and 26. The feedback suggests using the ${maven.compiler.release} property in the maven-compiler-plugin configuration within pom.xml to avoid duplicating the version number.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
…i review) Single source of truth: the compiler-plugin <release> now references the maven.compiler.release property instead of a hardcoded 25. Co-Authored-By: Claude <noreply@anthropic.com>
Post-merge amendment A1 to Plan 01: drop the "compile at 21, run at 25" split in favour of compiling and running on Java 25 (the LTS). Java 21 is not a target for this project.
Changes
pom.xml:maven.compiler.releaseand the compiler-plugin<release>21 → 25..github/project.yml:maven-build.java-versions["21","25"] → ["25","26"]; primaryjava-version21 → 25. Add"27"at its GA (~Sept 2026).doc/adr/0001-*: rewritten (status accepted; supersedes the proposed compile-low/run-high form).doc/plan/01-*: new Post-Merge Amendments → A1 section recording this change (the plan already merged, so it is amended, not rewritten).CLAUDE.md: project-overview + language-features lines updated to Java 25.Verification
Reactor compiles clean at
--release 25(bytecode major version 69 = Java 25) on a JDK 26 toolchain. The JDK-26 CI matrix leg is a forward-compatibility guard (the Lombok/Unsaferuntime warning under 26 is expected and non-blocking).Notes
jdk-25line (already 25 — unchanged).architecture.adoc/README.adoc/plan-02is updated in the sibling docs PR (docs/address-design-findings); the two PRs touch disjoint files.Summary by CodeRabbit
New Features
Documentation