chore(steward): non-vacuous ADR-0005 arch gate + marshal.json reconcile - #135
Merged
Conversation
The rule ran with allowEmptyShould(true), so a renamed or misspelled entry in AGNOSTIC_PACKAGES would have matched zero classes, found zero violations, and stayed green while protecting nothing. Drop that setting on the real rule and add a guard asserting every protected package resolves to at least one production class, naming the offending entry when it does not. Also extend FRAMEWORK_PACKAGES with io.smallrye.., io.netty.. and org.jboss..: the class Javadoc already names the SmallRye Fault-Tolerance guard as the coupling that keeps routing out of the agnostic set, and Netty/JBoss arrive transitively with the Quarkus/Vert.x stack. The negative control keeps allowEmptyShould(true) deliberately — there it is load-bearing, so an emptied control package fails assertThrows loudly instead of passing for the wrong reason. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0192te7j2ceUn2ASBjuXzWPU
Steward upgrade against plan-marshall 0.1.1274: sync-defaults back-filled system.retention.no_plan_body_days and re-stamped the provisioning fields. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0192te7j2ceUn2ASBjuXzWPU
cuioss-oliver
enabled auto-merge
July 30, 2026 18:46
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Excluded labels (none allowed) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: cuioss/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two unrelated-in-origin but co-landed changes from a
/marshall-steward upgradepass:1.
test(arch)— make the ADR-0005 framework-agnostic gate non-vacuousFrameworkAgnosticArchTestran its real rule withallowEmptyShould(true). A renamedpackage or a single misspelled entry in
AGNOSTIC_PACKAGESwould therefore have matchedzero classes, found zero violations, and stayed green while protecting nothing. The
existing negative control could not catch that — it exercises its own hardcoded package,
so it proves the ArchUnit mechanism works while saying nothing about whether the real
package list still resolves.
allowEmptyShould(true)from the real rule.everyAgnosticPackageResolvesToClasses(), which asserts every entry inAGNOSTIC_PACKAGESresolves to at least one production class and names the offendingentry when it does not.
FRAMEWORK_PACKAGESwithio.smallrye..,io.netty..andorg.jboss... Theclass Javadoc already names the per-route SmallRye Fault-Tolerance guard as precisely the
coupling that keeps
routingout of the agnostic set; leaving it unlisted would let anagnostic-core class acquire that same coupling unchecked. Netty and JBoss arrive
transitively with the Quarkus/Vert.x stack and are framework by any reading of ADR-0005.
allowEmptyShould(true)deliberately — there theasymmetry is load-bearing: an emptied control package makes
checkpass, which makesassertThrowsfail loudly, telling us the control stopped controlling anything.2.
chore(steward)— reconcilemarshal.jsonSteward upgrade against plan-marshall
0.1.1274:sync-defaultsback-filledsystem.retention.no_plan_body_daysand re-stamped the provisioning fields. Executorregenerated (141 scripts); 30 superseded plugin-cache version dirs pruned.
Verification
verify -Ppre-commitpassed (exit 0, 231s).Review
Labelled
skip-bot-review.