Add directory hierarchy awareness to document sorting#517
Merged
davidjgoss merged 3 commits intoJul 2, 2026
Merged
Conversation
davidjgoss
approved these changes
Jul 2, 2026
davidjgoss
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks for doing this.
Contributor
Author
Thanks for reviewing my PR. I would love to continue contributing to the repository. Are there any specific issues you'd recommend I consider next. |
Member
|
@MuhammadTalha57 what do you think of implementing #126? |
Contributor
Author
Thanks for the suggestion. I've opened a PR implementing #126 and would appreciate your feedback whenever you have a chance to review it. PR: #524 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
This PR updates the document sorting logic so nested directories are ordered before direct child files, matching how users typically expect hierarchy-aware sorting to behave in IDEs and file explorers.
⚡️ What's your motivation?
Fixes #492.
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
I’d especially appreciate feedback on the test coverage I added. I couldn’t find a more appropriate place for these tests, so I added them in the samples folder, which also appears to be how the previous implementation was covered.
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.