fix(api-gateway): guard root orderBy cube name capitalization - #11783
Open
Tyagiquamar wants to merge 1 commit into
Open
fix(api-gateway): guard root orderBy cube name capitalization#11783Tyagiquamar wants to merge 1 commit into
Tyagiquamar wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check List
Issue Reference this PR resolves
Closes #11700
Description of Changes Made
In
packages/cubejs-api-gateway/src/graphql.ts(getJsonQuery), the rootorderByhandler was unconditionally capitalizing the cube name (capitalize(cubeName)). When querying a cube declared with a lowercase-first or snake_case name (e.g.orders,lowercaseOrders), this resulted in non-existent order paths (such asOrders.count) causing query resolution errors under the Tesseract planner.This change checks whether the cube already exists in
metaConfigunder its un-capitalized name before falling back tocapitalize(cubeName), aligning with the existing pattern used inwhereArgToQueryFilters,getMemberType, and the per-cubeorderByhandler.