fix(cubesql): preserve floating-point literal types in pushdown SQL - #11781
Open
davidda wants to merge 1 commit into
Open
fix(cubesql): preserve floating-point literal types in pushdown SQL#11781davidda wants to merge 1 commit into
davidda wants to merge 1 commit into
Conversation
Render Float32 and Float64 literals through dialect casts so integral-valued floats do not become integer arithmetic after serialization or constant folding. This follows existing decimal literal handling and preserves intentional integer division. Explicit float typing can change source-inferred decimal arithmetic and requires compatible dialect cast support. Add renderer and planner regressions and update affected SQL expectations. Validation: 821 compiler tests passed, 6 ignored; workspace formatting and all-targets Clippy passed. Cross-dialect end-to-end validation remains outstanding.
github-actions
Bot
added
rust
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Render Float32 and Float64 literals through dialect casts so integral-valued floats do not become integer arithmetic after serialization or constant folding. This follows existing decimal literal handling and preserves intentional integer division.
Explicit float typing can change source-inferred decimal arithmetic and requires compatible dialect cast support. Add renderer and planner regressions and update affected SQL expectations.
Validation: 821 compiler tests passed, 6 ignored; workspace formatting and all-targets Clippy passed. Validated on a running instance for MSSQL.
Check List
Issue Reference this PR resolves
#11780