-
Notifications
You must be signed in to change notification settings - Fork 2.1k
feat(backend-native, server-core): support the chatCompletion config hook #11733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
paveltiunov
wants to merge
4
commits into
master
Choose a base branch
from
claude/llm-gateway-byom-ytuaf7
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
6a8b759
docs: document the LLM Gateway BYOM provider
claude 83126b0
feat(backend-native, server-core): support the chatCompletion config …
claude fbdf0c0
test(backend-native): pin that a Python None crosses as undefined
claude 6654fec
fix: address review on the chatCompletion config hook
claude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 18 additions & 0 deletions
18
packages/cubejs-backend-native/test/config-chat-completion-object.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| from cube import config | ||
|
|
||
| config.schema_path = "models" | ||
|
|
||
|
|
||
| class NotBridgeable: | ||
| """An arbitrary Python object, standing in for a LangChain chat model.""" | ||
|
|
||
| def stream(self, messages): | ||
| return [] | ||
|
|
||
|
|
||
| # Documents the boundary the two supported forms exist to work around: an | ||
| # arbitrary Python object has no cross-language representation, so it reaches | ||
| # JavaScript as an unrepresentable reference and throws there. | ||
| @config | ||
| def chat_completion(request): | ||
| return NotBridgeable() |
20 changes: 20 additions & 0 deletions
20
packages/cubejs-backend-native/test/config-chat-completion-stream.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| from cube import config | ||
|
|
||
| config.schema_path = "models" | ||
|
|
||
|
|
||
| # Streaming form of the `chat_completion` hook. A Python async generator cannot | ||
| # cross the bridge to JavaScript, so a streamed response is handed back as a | ||
| # `next` function that yields one chunk per call and None when complete — | ||
| # closing over whatever iterator the gateway call produced. | ||
| @config | ||
| def chat_completion(request): | ||
| tokens = iter(["strea", "med ", request["model"]]) | ||
|
|
||
| async def next_chunk(): | ||
| try: | ||
| return {"content": next(tokens)} | ||
| except StopIteration: | ||
| return None | ||
|
|
||
| return {"next": next_chunk} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.