Skip to content

add language_server_workspace_configuration trait method#9

Open
Sam-Sims wants to merge 1 commit into
ctuni:mainfrom
Sam-Sims:feat/workspace_config
Open

add language_server_workspace_configuration trait method#9
Sam-Sims wants to merge 1 commit into
ctuni:mainfrom
Sam-Sims:feat/workspace_config

Conversation

@Sam-Sims
Copy link
Copy Markdown

@Sam-Sims Sam-Sims commented May 15, 2026

hello!

I've recently moved to Zed and so I am in need of a Nextflow plugin, and came across this one - nice work.

I have been attempting to get workspace features working in Zed, see - nextflow-io/language-server#122 (comment)

This PR implements the language_server_workspace_configuration trait method using the defaults I could find in the VScode package.json here. This provides out of the box defaults, but a user should be able to override in the Zed settings if needed.

ATM defaults are needed because the language server initializeWorkspaces function is only called from didChangeConfiguration - so we need to send a config change to trigger workspace init.

In combination with nextflow-io/language-server#156 I now have inline diagnostics and ctrl-click navigation working:

screenshot-2026-05-14_15-52-47

On a separate note I also updated the pinned nextflow tree sitter version to the latest revision (which only needed some minor changes). I havent included them in this PR but happy to open one if worth updating

@DLBPointon
Copy link
Copy Markdown
Contributor

Absolutely amazing, nice work!

Maybe hold off on updating the language server version until your changes have been merged into it?

@Sam-Sims
Copy link
Copy Markdown
Author

Sam-Sims commented May 21, 2026

In this case I mean the revision of https://github.com/nextflow-io/tree-sitter-nextflow that is pinned in extension.toml - my PR was for the language server so shouldn't block each other.

I opened an issue #10 to track as it seems like syntax highlighting can be a bit spotty for me, however the syntax tree has lots of errors parsing my nf code, so the treesitter might also need some upstream fixes. I had hoped updating the tree-sitter-nextflow version might help, but think it created more errors 😀

I don't want to spam PRs but happy to open a draft one to document my progress if anyone wants to have a look. I aim to work through issues and fix them as they come up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants