add language_server_workspace_configuration trait method#9
Conversation
|
Absolutely amazing, nice work! Maybe hold off on updating the language server version until your changes have been merged into it? |
|
In this case I mean the revision of https://github.com/nextflow-io/tree-sitter-nextflow that is pinned in I opened an issue #10 to track as it seems like syntax highlighting can be a bit spotty for me, however the syntax tree has lots of errors parsing my nf code, so the treesitter might also need some upstream fixes. I had hoped updating the tree-sitter-nextflow version might help, but think it created more errors 😀 I don't want to spam PRs but happy to open a draft one to document my progress if anyone wants to have a look. I aim to work through issues and fix them as they come up. |
hello!
I've recently moved to Zed and so I am in need of a Nextflow plugin, and came across this one - nice work.
I have been attempting to get workspace features working in Zed, see - nextflow-io/language-server#122 (comment)
This PR implements the
language_server_workspace_configurationtrait method using the defaults I could find in the VScodepackage.jsonhere. This provides out of the box defaults, but a user should be able to override in the Zed settings if needed.ATM defaults are needed because the language server initializeWorkspaces function is only called from didChangeConfiguration - so we need to send a config change to trigger workspace init.
In combination with nextflow-io/language-server#156 I now have inline diagnostics and
ctrl-click navigation working:On a separate note I also updated the pinned nextflow tree sitter version to the latest revision (which only needed some minor changes). I havent included them in this PR but happy to open one if worth updating