Conversation
|
Thanks a lot for this fix @ctuni ! Let me know if you want me to test it in my system again, i think if it worked in your machine it should work in mine too. |
|
I rebuild the wasm exetension from the dev branch and from Zed Extensions UI, I uninstall the extension and go to Install Dev Extension and click on the folder. It doesn't let me select the actual wasm file, idk if that's what I have to do. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

There were a couple of issues as described by @davidmasp in his comment here.
The formatter issue could not be fixed: when users save a .nf file, Zed asks the Nextflow language server to format it. The LSP refuses and returns the error "Script could not be formatted because it has syntax errors." This comes from the language server's own internal parser, which is separate from the tree-sitter grammar.
The fix was to document in the README the workarround to skip this step as documented by @davidmasp.
The other issue, the double imports one, was fixed by adding the ";" in the include rule in the grammar:
Now double imports, semi-colon separated, look like they should!