Skip to content
This repository was archived by the owner on Oct 1, 2025. It is now read-only.

Removes block that deletes schema on disable - #65

Open
michael-bentz wants to merge 1 commit into
ctsit:developfrom
michael-bentz:remove_destroy_on_disable
Open

Removes block that deletes schema on disable#65
michael-bentz wants to merge 1 commit into
ctsit:developfrom
michael-bentz:remove_destroy_on_disable

Conversation

@michael-bentz

@michael-bentz michael-bentz commented Jan 12, 2021

Copy link
Copy Markdown

Closes #60

Removes EntityDB::dropSchema($this->PREFIX); from redcap_module_system_disable hook.

@ChemiKyle

ChemiKyle commented Jan 12, 2021

Copy link
Copy Markdown
Contributor

I'd remove the redcap_module_system_disable function override entirely.

I would've put this as a suggestion but there's one line in the docstring that github won't allow me to use in suggestions :(

@michael-bentz
michael-bentz force-pushed the remove_destroy_on_disable branch from 88f82c3 to f0e2ae3 Compare January 13, 2021 13:20
@michael-bentz

Copy link
Copy Markdown
Author

I'd remove the redcap_module_system_disable function override entirely.

I would've put this as a suggestion but there's one line in the docstring that github won't allow me to use in suggestions :(

Function has been removed entirely. 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants