Datatables upgrade#622
Open
droberts-ctrlo wants to merge 17 commits into
Open
Conversation
Also removed extra yarn commands that weren't needed, and automated download of browserslist updates on build.
…changed Removed cjs from eslint - cjs are used for internal development files, and should never be included
… dev branch Updated files where dev changes weren't included
Updated documentation Fixed formatting and code where this was broken on merge with current dev branch Added fix for error on documentComponent Updated code files with changes as required where they were included in dev Updated file where missing function wasn't included
Updated code files with changes as required where they were included in dev
Updated to use new switch component for fullscreen
… dev branch Updated and removed extra dependencies and exports where not required Further package changes and TSConfig updates Removed knip Removed extra unused dependencies Updated with changes within current dev Updated code files with changes as required where they were included in dev Updated file where missing function wasn't included Fixed error in markdown that was missed during upgrade
pwlodarski-ctrlo
left a comment
pwlodarski-ctrlo
left a comment
There was a problem hiding this comment.
PR reviewed - just a few clarifications.
droberts-ctrlo
force-pushed
the
datatables-upgrade
branch
from
2297284 to
d06d213
Compare
droberts-ctrlo
force-pushed
the
datatables-upgrade
branch
from
d06d213 to
b4707e6
Compare
pwlodarski-ctrlo
left a comment
pwlodarski-ctrlo
left a comment
There was a problem hiding this comment.
Final PR review - all good!
Contributor
Author
|
On checking, DataTables is currently broken in this build. Do not merge for now. |
Contributor
Author
|
Fixes now complete - Cypress and Webdriver tests will not pass as there is no build |
Contributor
Author
Jest currently arguing - will fix then push changes from review |
Contributor
Author
|
Jest fixed - issue was local to my machine |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.