Js refactor#620
Merged
Merged
Conversation
Also removed extra yarn commands that weren't needed, and automated download of browserslist updates on build.
Updated error handler
…changed Removed cjs from eslint - cjs are used for internal development files, and should never be included
Updated documentation Fixed formatting and code where this was broken on merge with current dev branch Added fix for error on documentComponent Updated code files with changes as required where they were included in dev Updated file where missing function wasn't included
Also removed extra yarn commands that weren't needed, and automated download of browserslist updates on build.
Further package changes and TSConfig updates Removed knip
Updated code files with changes as required where they were included in dev
Updated file where missing function wasn't included
droberts-ctrlo
force-pushed
the
js-refactor
branch
from
22bf65c to
8f78543
Compare
pwlodarski-ctrlo
left a comment
pwlodarski-ctrlo
left a comment
There was a problem hiding this comment.
PR Reviewed, apart from a singular clarification, all good!
| @@ -1,5 +1,5 @@ | |||
| import 'jstree'; | |||
| import 'datatables.net'; | |||
| import 'datatables.net-bs4'; | |||
There was a problem hiding this comment.
Just to confirm, is this meant to be BS4 or BS5?
Contributor
Author
There was a problem hiding this comment.
BS4 - BS5 will be in a few PR's time
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.