DRYD-1898: Procedure > Bot Garden > Modify Current Location#209
DRYD-1898: Procedure > Bot Garden > Modify Current Location#209spirosdi wants to merge 2 commits into
Conversation
mikejritter
left a comment
mikejritter
left a comment
There was a problem hiding this comment.
Changes look ok. I didn't see a source for the geoRefProtocol and geoRefVerificationStatus lists so I didn't do any extra checking of them.
A few small nits I noticed which I don't think change any functionality but just the config output.
| <title-ref>geoRefProtocol</title-ref> | ||
| <title>Georeference Protocol</title> | ||
| <options> | ||
| <option id="chapmanWieczorek2006GuideBestPracticesGeoreferencing">Chapman, Wieczorek 2006, Guide to Best Practices for Georeferencing</option> |
There was a problem hiding this comment.
We could shorten the ids here if we want. I think it will be encoded in the short id of the refname which creates some noise but not really an issue otherwise.
| <section id="geoReferenceInformation"> | ||
| <field id="decimalLatitude" datatype="float" section="botgarden"/> | ||
| <field id="decimalLongitude" datatype="float" section="botgarden"/> | ||
| <field id="geodeticDatum" section="botgarden" ui-type="enum"/> |
There was a problem hiding this comment.
If this is an OptionPickerInput in the ui, I believe we should remove the ui-type="enum" from the field definition. IIRC this causes it to be typed as a TermRef in the tenant bindings which expects that the value conforms to a refname.
I don't believe any errors actually are created by this (I've done it before... maybe with autocomplete as well though), just a bit of inconsistency in the backend config.
| <field id="geoRefProtocol" section="botgarden" ui-type="enum" autocomplete="vocab-geoRefProtocol"/> | ||
| <field id="geoRefSource" section="botgarden" ui-type="enum" autocomplete="vocab-geoRefSource"/> | ||
| <field id="geoRefVerificationStatus" section="botgarden" ui-type="enum" autocomplete="vocab-geoRefVerificationStatus"/> |
There was a problem hiding this comment.
The autocomplete="vocab-*" can be changed to autocomplete="true" here. The references to the vocab term list ids seems like it's from how the application used to be configured but is no longer used.
2 participants
What does this do?
geoReferenceInformationsection containing the new fields to thebotgarden-procedure-movementactionCodesWhy are we doing this? (with JIRA link)
Enabling tracking lat/long information at the current location procedure level: https://collectionspace.atlassian.net/browse/DRYD-1898
How should this be tested? Do these changes have associated tests?
Please follow the instructions at the:
cspace-deployment/cspace-ui-plugin-profile-ucbg.js#85
Dependencies for merging? Releasing to production?
It should be merged and releases along these PRs:
cspace-deployment/services#450
cspace-deployment/cspace-ui-plugin-profile-ucbg.js#85
Has the application documentation been updated for these changes?
N/A
Did someone actually run this code to verify it works?
@spirosdi ran this locally
Have any new accessibility violations been handled?
N/A