Update Handling of Committed Trades - #409
Merged
Merged
Conversation
Some trades can linger in the `Committed` state without ever reaching `Complete`. Since they are functionally equivalent, we need to report them server-side as well. Ref CSF-1717
GODrums
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some trades can linger in the
Committedstate without ever reachingComplete. Since they are functionally equivalent, we need to report them server-side as well.Ref CSF-1717
Note
Medium Risk
Changes which Steam trade statuses are forwarded for marketplace verification; mis-filtering could miss or over-report trades, but scope is limited to one filter in the alarms trade-history path.
Overview
Trade history reporting now treats Steam trades in
Committedstatus the same as completed ones when building history fromGetTradeHistory.getTradeHistoryFromAPIpreviously kept onlyCompleteandTradeProtectionRollbackentries. The filter also allowsTradeStatus.Committed, so trades that never transition toCompletebut are already exchanged still reach CSFloat verification viapingTradeHistory. Escrow and CS:GO asset mapping behavior is unchanged.Reviewed by Cursor Bugbot for commit 13db4d0. Bugbot is set up for automated code reviews on this repo. Configure here.