Repository navigation
Conversation
Remember the pre-fullscreen module state and re-dock on exit when the module was docked, instead of always leaving an undocked window. Fixes csete#441.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exiting fullscreen always set the module state to WINDOW and only called
gtk_window_unfullscreen. Modules that entered fullscreen from the notebook had already been undocked into a temporary top-level window, so leaving fullscreen left that window behind and an empty notebook — matching #441.This remembers the pre-fullscreen state on
GtkSatModule. Leaving fullscreen re-docks when that state was DOCKED (same path as Attach module) and keeps the previous undocked-window behavior when it was WINDOW. Startup / reconfigure paths that build a fullscreen top-level window set the remembered state to WINDOW so Exit full screen still behaves there../autogen.sh && ./configure && makeandmake checkpass.Fixes #441