Add delete action to SD card file menu#360
Open
brannum wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for specter-diy-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
Tested it and it works. But I would:
Also I would add a format everything button after you click on delete, so that everything on the SD card gets reliably deleted. 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #359.\n\nThis adds a delete flow to the existing
Open SD card filemenu:\n\n- keeps the current grouped file picker for.psbt,.txt, and.jsonfiles\n- adds aDelete fileaction from that menu\n- asks the user to pick the SD card file to delete\n- confirms before removing the file\n- returns to file selection after deleting, or exits cleanly if the last matching file was removed\n\nTests:\n\n-PYTHONPATH=test:src:. .venv/bin/python -m unittest tests_native.test_sd_host_file_menu -v\n-.venv/bin/python test/run_native_tests.py