Repository navigation
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Unresolved cleanup lifetime errors and inspection bypasses prevent safe approval.
7 open findings
What changed in this PR
Adds AppSec inspection and bot-detection challenges to the Apache CrowdSec bouncer alongside existing local API decisions.
Changes:
- Adds request forwarding, body capture and replay, and challenge response handling.
- Introduces AppSec configuration and bounded verdict parsing.
- Adds unit and integration coverage with a stub AppSec service.
| File | Description |
|---|---|
| test/unit/t_verdict.c | Tests AppSec verdict parsing and validation. |
| test/README.md | Documents AppSec tests and live-engine checks. |
| test/lib/stub_appsec.py | Simulates AppSec responses and records requests. |
| test/lib/harness.sh | Adds AppSec lifecycle helpers and runtime directory configuration. |
| test/bats/challenge.bats | Tests challenge responses, cookies, and endpoints. |
| test/bats/appsec.bats | Tests forwarding, verdicts, and failure policies. |
| test/bats/appsec-body.bats | Tests body inspection, replay, and limits. |
| mod_crowdsec.c | Integrates AppSec checks and configuration directives. |
| Makefile.am | Includes AppSec sources in the build. |
| crowdsec_verdict.h | Defines AppSec verdict structures and bounds. |
| crowdsec_verdict.c | Parses and validates AppSec responses. |
| crowdsec_config.h | Adds AppSec settings and defaults. |
| crowdsec_appsec.h | Declares AppSec interfaces and request state. |
| crowdsec_appsec.c | Implements inspection, replay, and challenge serving. |
| config/crowdsec-apache2-bouncer.conf | Documents optional AppSec configuration. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+538
to
539
| if (!sconf->url && !sconf->appsec_url) { | ||
| continue; |
| rem = crowdsec_rem_merge(rem, CROWDSEC_REM_BAN); | ||
| break; | ||
| case CROWDSEC_APPSEC_BADREQ: | ||
| return HTTP_BAD_REQUEST; |
buixor
force-pushed
the
lapi-revamp-stage2-waf-and-bot-support
branch
from
October 16, 2026 13:02
d95f393 to
5031013
Compare
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
buixor
commented
Oct 20, 2026
| /* True for the challenge's own assets and submit endpoint. Matched on the | ||
| * decoded path so a traversal cannot dodge it. | ||
| */ | ||
| int crowdsec_is_challenge_path(const char *uri, const char *prefix); |
Collaborator
Author
There was a problem hiding this comment.
check this: it seems fragile. shouldn't we want it to be enabled "server wide" and disabled in some specific location ?
buixor
commented
Oct 20, 2026
|
|
||
| <Location /> | ||
| Crowdsec On | ||
| CrowdsecAppsec On |
Collaborator
Author
There was a problem hiding this comment.
In documentation we want to suggest to enable the bouncer and appsec globally (per vhost) and just show that you can disable it in specific locations.
buixor
commented
Oct 20, 2026
| |---|---|---|---| | ||
| | `Crowdsec` | S+D | `Off` | Check requests in this scope. | | ||
| | `CrowdsecBlockedHTTPCode` | S+D | `429` | Status for a blocked client: `429`, `403` or `500`. | | ||
| | `CrowdsecLocation` | S+D | — | Redirect a blocked client here instead. Supports expressions, e.g. `/blocked?ip=%{REMOTE_ADDR}`. | |
Collaborator
Author
There was a problem hiding this comment.
investigate:
- is this an internal redirect ?
- if not, we might want to do the same approach as for nginx bouncer, where the bouncer just serves a static html that the user can override
buixor
commented
Oct 20, 2026
| |---|---|---|---| | ||
| | `CrowdsecAppsecURL` | S | — | AppSec address: `http://127.0.0.1:7422` or `unix:/run/crowdsec/appsec.sock`. Unset disables AppSec. | | ||
| | `CrowdsecAppsecPath` | S | `/` | Path AppSec listens on. Must match the datasource's `path`. | | ||
| | `CrowdsecAppsec` | S+D | `Off` | Send requests in this scope for inspection. | |
Collaborator
Author
There was a problem hiding this comment.
CrowdsecAppsec should be on by default as long as the AppSecURL is configured
buixor
commented
Oct 20, 2026
|
|
||
| ## Known limits | ||
|
|
||
| **A gzipped request body is inspected compressed.** The body is captured before |
Collaborator
Author
There was a problem hiding this comment.
investigate : perform a test on live vm, the appsec should decompress the body.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.