chore: add Firefox to the list of supported browsers#4
Open
matteoscopel wants to merge 1 commit into
Open
Conversation
📝 WalkthroughWalkthroughThe PR updates a single line in the public HTML documentation to reflect current Web flasher browser support, adding Firefox to the list of compatible browsers alongside Chrome and Edge for desktop WebSerial-based USB flashing. ChangesBrowser Compatibility Documentation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
public/index.html (1)
880-885:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winAlign browser support copy in the warning with the updated compatibility statement.
Line 880 now includes Firefox, but Line 884 still says flashing requires only Chrome or Edge. This creates conflicting guidance in the same section.
Suggested fix
- <span class="font-semibold">Flashing unavailable.</span> The web flasher uses WebSerial, which requires Chrome or Edge on desktop. You can still browse firmware info and changelogs below. + <span class="font-semibold">Flashing unavailable.</span> The web flasher uses WebSerial, which requires Chrome, Edge, or Firefox on desktop. You can still browse firmware info and changelogs below.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@public/index.html` around lines 880 - 885, The two browser support statements conflict: the paragraph mentions Firefox but the warning (div id="browser-warning") says flashing requires only Chrome or Edge; update the warning copy inside `#browser-warning` to match the paragraph by including Firefox (e.g., "requires Chrome, Edge, or Firefox on desktop") or otherwise make both statements consistent so users see the same compatibility message.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@public/index.html`:
- Around line 880-885: The two browser support statements conflict: the
paragraph mentions Firefox but the warning (div id="browser-warning") says
flashing requires only Chrome or Edge; update the warning copy inside
`#browser-warning` to match the paragraph by including Firefox (e.g., "requires
Chrome, Edge, or Firefox on desktop") or otherwise make both statements
consistent so users see the same compatibility message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of the latest Firefox release, flashing the firmware works from there too now. I've added it to the list of supported browsers.