Skip to content

fix: standardize MAX_RECV_MESSAGE_SIZE environment variable #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fernandezcuesta wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: standardize MAX_RECV_MESSAGE_SIZE environment variable #593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,7 @@ environment variable. Setting the default-options to "missingkey=error" will ca
engine to return an error when a missing key is detected, instead of setting the value to "<no value>".

The maximum size of received messages (in MB) defaults to `4`. This can be overridden by the
`--max-recv-message-size` CLI flag or the `FUNCTION_GO_TEMPLATING_MAX_RECV_MESSAGE_SIZE`
environment variable.
`--max-recv-message-size` CLI flag or the `MAX_RECV_MESSAGE_SIZE` environment variable.

### Connection Details

Expand Down
2 changes: 1 addition & 1 deletion main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ type CLI struct {
TLSCertsDir string `env:"TLS_SERVER_CERTS_DIR" help:"Directory containing server certs (tls.key, tls.crt) and the CA used to verify client certificates (ca.crt)"`
Insecure bool `help:"Run without mTLS credentials. If you supply this flag --tls-server-certs-dir will be ignored."`
TTL string `default:"${defaultTTL}" help:"Function global setting for response TTL."`
MaxRecvMessageSize int `default:"4" env:"FUNCTION_GO_TEMPLATING_MAX_RECV_MESSAGE_SIZE" help:"Maximum size of received messages in MB."`
MaxRecvMessageSize int `default:"4" env:"MAX_RECV_MESSAGE_SIZE" help:"Maximum size of received messages in MB."`
DefaultSource string `default:"" env:"FUNCTION_GO_TEMPLATING_DEFAULT_SOURCE" help:"Default template source to use when input is not provided to the function."`
DefaultOptions string `default:"" env:"FUNCTION_GO_TEMPLATING_DEFAULT_OPTIONS" help:"Comma-separated default template options to use when input is not provided to the function."`
}
Expand Down
Loading