Crossplane v1-compatible build of function-extra-resources - #111
Merged
Conversation
Signed-off-by: Jakub Ramut <jakub@upbound.io>
Signed-off-by: Jakub Ramut <jakub@upbound.io>
jakubramut
force-pushed
the
feat/crossplane-v1
branch
from
July 28, 2026 15:23
b1afab9 to
9f3aff5
Compare
phisco
reviewed
Jul 28, 2026
Signed-off-by: Jakub Ramut <jakub@upbound.io>
phisco
requested changes
Jul 28, 2026
phisco
left a comment
Collaborator
There was a problem hiding this comment.
Constraint and README look right now. One thing left.
Collaborator
|
Longer term, return |
…ty guard Signed-off-by: Jakub Ramut <jakub@upbound.io>
Contributor
Author
|
@phisco, |
2 tasks
Crossplane only defaults a Function to the composition capability when no capabilities are declared at all, so an empty list would silently break every composition using this function. Signed-off-by: Philippe Scorsolini <5697904+phisco@users.noreply.github.com>
The namespace is not honored server-side on Crossplane v1 and never matches a cluster-scoped kind on either major. The Reference not-found error also blamed the Crossplane version for what is usually a typo. Signed-off-by: Philippe Scorsolini <5697904+phisco@users.noreply.github.com>
Signed-off-by: Philippe Scorsolini <5697904+phisco@users.noreply.github.com>
Follow-ups for Crossplane v1 compatibility
phisco
self-requested a review
July 29, 2026 11:37
phisco
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
What
Why
Upstream main (v0.3.0+) moved to the v2-only protocol fields, so it silently no-ops on Crossplane v1. This stream restores v1 support while staying dual-compatible: it uses the deprecated fields, which Crossplane v2 still resolves.
How has this code been tested
--max-recv-message-size: verified it raises the function's request-recv limit (function accepted a 5.4 MB request that the 4 MB default rejected).I have: