fix: avoid session flash during console install#46
Merged
Conversation
Contributor
|
Hi @boboldehampsink , Thanks for your contribution here, I can't see any issues with the code you have committed. The only thing to note is that we use a Conventional Commits workflow, tied to our release cycle. We therefore require any PR's/Commits to be tacked with the relevant structure to build our changelog. In your case just putting You can find more about conventional commits here: https://www.conventionalcommits.org/en/v1.0.0/ |
578e497 to
b489dde
Compare
Contributor
|
Thanks again @boboldehampsink. This code is now published and available in release v4.3.3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
When Craft installs plugins from project config in a console command, migration output may already have been sent before
EVENT_AFTER_INSTALL_PLUGINfires. CallingCraft::$app->session->setError()in that path can triggersession_name(): Session name cannot be changed after headers have already been sentand abort installation.