fix: add console request check to EVENT_BEFORE_SEND handler#45
Merged
Conversation
The Mailer EVENT_BEFORE_SEND handler calls getBodyParam() which only exists on craft\web\Request. When emails are sent from queue jobs (console context), this crashes with UnknownMethodException. Adds a console request check to skip the handler in CLI context, fixing compatibility with plugins like Formie that send emails via queue jobs. Fixes creode#44
creode-dev
changed the title
Contributor
|
Thanks for your contribution and detailed issue log for this one. I'll merge this in now and push a new release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mailer::EVENT_BEFORE_SENDhandler to skipgetBodyParam()calls in CLI/queue contextProblem
The
EVENT_BEFORE_SENDhandler atMagicLogin.php:156calls$this->request->getBodyParam('magicLoginRegistration')on every email sent. When emails are sent from queue jobs (e.g., Formie notifications), the request iscraft\console\Requestwhich doesn't havegetBodyParam(), causing:This breaks all queued email notifications from any plugin (Formie, etc).
Fix
Added a
getIsConsoleRequest()check before callinggetBodyParam(). In console context the handler returns early — the magic login registration check is only relevant during web requests anyway.Fixes #44