Repository navigation
Prometheus telemetry - #8
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces Prometheus/OpenTelemetry-based telemetry to expose runtime metrics (disk temperature/activity and fan zone speed) and adds a built-in HTTP endpoint for scraping, while also updating the simulation RNG to math/rand/v2 with two seeds.
Changes:
- Add OpenTelemetry metric instrumentation for disks and fan zones, with a Prometheus exporter.
- Add an HTTP metrics server and wire telemetry/metrics startup + shutdown into
main. - Switch simulation RNG seeding to two
uint64seeds and migrate tomath/rand/v2.
Reviewed changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| telemetry.go | Creates the OTel Prometheus exporter and initializes telemetry. |
| metrics.go | Adds the /metrics HTTP server endpoint. |
| main.go | Wires telemetry + metrics server lifecycle into startup/shutdown. |
| lib/telemetry.go | Defines OTel metrics (observable gauges) for disks and fan zones. |
| lib/zone.go | Adds CurrentSpeed() accessor used by telemetry. |
| lib/control.go | Minor logging message change. |
| lib/global.go | Switches simulation RNG to math/rand/v2 PCG with two seeds. |
| lib/simulation/sensor.go | Migrates simulated sensors to math/rand/v2. |
| lib/simulation/sensor_test.go | Updates tests for math/rand/v2 seeding. |
| flags.go | Replaces single simulation seed flag with two seed flags. |
| cfg/config.go | Adds telemetry config and replaces seed config with two seeds. |
| config.yaml | Adds telemetry configuration example. |
| go.mod | Adds Prometheus + OpenTelemetry metric dependencies. |
| go.sum | Updates module checksums for new dependencies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.