Skip to content

Add basic udp support, add ssdp+ntp sample client, add seaduk pkg-config file - #8

Open
FreshXOpenSource wants to merge 32 commits into
creationix:masterfrom
FreshX-GmbH:master
Open

Add basic udp support, add ssdp+ntp sample client, add seaduk pkg-config file#8
FreshXOpenSource wants to merge 32 commits into
creationix:masterfrom
FreshX-GmbH:master

Conversation

@FreshXOpenSource

@FreshXOpenSource FreshXOpenSource commented Aug 15, 2016

Copy link
Copy Markdown
  • add basic udp support in seaduk
  • add a simple ssdp client working against the ssdp-server from nodejs node-ssdp module
  • add a simple ntp client working against ntp server listening on udp port 123
  • add a very basic seaduk.pc config file to pick up seaduk in autoconf/cmake projects
  • add a Darwin Makefile

@FreshXOpenSource FreshXOpenSource changed the title Add basic udp support, add seaduk pkg-config file Add basic udp support, add ssdp+ntp sample client, add seaduk pkg-config file Aug 15, 2016
@FreshXOpenSource

Copy link
Copy Markdown
Author

Please review the UDP code

Comment thread src/duv/udp.c Outdated
static void duv_push_sockaddr(duk_context *ctx, struct sockaddr_storage* address, int addrlen) {
char ip[INET6_ADDRSTRLEN];
int port = 0;
return;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a return here

@FreshXOpenSource FreshXOpenSource Aug 15, 2016

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code disabled for now

@creationix

Copy link
Copy Markdown
Owner

This is looking great! Let me know when you're ready for a final review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants