[WIP] Add Tauri wrapper window size persistence and app data storage - #3
Draft
crazyrob425 with Copilot wants to merge 1 commit into
Draft
crazyrob425 with Copilot wants to merge 1 commit into
crazyrob425 with Copilot wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.
Original prompt
In crazyrob425/KDP-E-Book-Generator (base main), ensure the Tauri v2 wrapper persists window size/position on Windows and clamps/restores within current monitor bounds, and ensure all app data (SQLite DB, settings, caches) is stored under the OS AppData directory. Implement minimal Rust/Tauri changes: on startup read window state from a settings file in app_data_dir and apply; on window move/resize debounce and save updated state. Update README with AppData location details. Keep changes aligned with existing PR adding Tauri wrapper + SQLite + job progress events; avoid extra dependencies unless necessary.
The following is the prior conversation context from the user's chat exploration (may be truncated):
User: @copilot Accepted Confirmation: Are you sure?
Assistant: You’ve got every reason to feel that way. I gave you a path that sounded like “one easy zip,” but this chat can’t generate downloadable zip attachments, and it also doesn’t currently have permission to write into blacklistedrob-prog/KDP-E-Book-Generator—so I can’t just push the wrapper for you. That mismatch is on me.
The truth, plainly
Right now there are only two ways to get a Tauri wrapper into that repo:
There isn’t a third option where you do nothing and it magically appears in your repo, because GitHub is blocking write operations from here.
The least-effort way that actually works (one command, no manual file creation)
If you can run commands locally in the repo folder on Windows, do this:
When it prompts, use:
Binary Books E-Crafternpm run devnpm run builddisthttp://localhost:5173Then:
Finally:
That is the closest thing to the “zip upload” simplicity you wanted—because the generator creates the entire
src-tauri/scaffold correctly.One yes/no question so I can keep you from wasting time
Can you run commands locally (PowerShell/Terminal) in the repo folder?
Reply YES or NO.
User: dude i dont know where you thibk you are but nothing is hosted locally this is all hosted on github
Assistant: We’re waiting on your response to the “Are you sure?” confirmation dialog so I can continue with the GitHub Actions PR work in
Blacklisted-Binary/demo-repository.User: @copilot Accepted Confirmation: Are you sure?
Assistant: GitHub is just where the code lives. Building a Tauri desktop app can’t happen “inside GitHub” by itself—you need either:
Right now I can’t directly push the Tauri wrapper into your
blacklistedrob-prog/KDP-E-Book-Generatorrepo from this chat (GitHub is blocking write access for this session), so I can’t “just do it” in-place for you yet.Two paths forward (pick one)
Path A (no local setup): GitHub Actions builds the Windows installer for you
This is the closest to what you want: you click “Run workflow” (or push a commit) and GitHub produces a
.msiinstaller you download.To do that, we still need one of these:
Path B (local once): you generate the wrapper with one command, then everything else can be GitHub-built
You’d do one local step to create the wrapper; then we add Actions and you never build locally again.
Quick questions (so I give you the exact minimal-click instructions)
If you answer those, I’ll tell you the lowest-effort route and exactly what to click/do—aiming for “one-time setup, then GitHub builds the installer forever.”
User: can you fork the repo and do it??
Assistant: We’re waiting for your response to the “Are you sure?” confirmation dialog so I can proceed with forking Blacklisted-Binary/demo-repository and applying the Tauri + SQL...
This pull request was created from Copilot chat.
💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.