fix(BUG-009): require explicit nullable when alterColumn changes data type#146
Merged
Conversation
… type alterColumn() with newDataType but nullable=null silently made columns NOT NULL because null was mapped to 0. Now throws ZVecException with a clear message when newDataType is set without nullable. Closes #56
a7b7218 to
590f10c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes silent data constraint corruption in alterColumn(). When calling alterColumn() with newDataType but without specifying nullable, the method silently made columns NOT NULL because null was mapped to 0.
Problem
Solution
Throw ZVecException when newDataType is set without explicit nullable:
Changes
Tests
All 136 tests pass. Closes #56.