Skip to content

refactor(smell-014): decompose query() into focused helper methods #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
s2x merged 1 commit into from
May 30, 2026
Merged

refactor(smell-014): decompose query() into focused helper methods #145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,15 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed

- **SMELL-014: Decomposed `query()` (116 lines, 4+ responsibilities) into focused helpers** (#95)
- Extracted `resolveQueryParams()` — resolves parameters from explicit args or `ZVecVectorQuery` object, validates inputs
- Extracted `executeQuery()` — performs FFI call with FP32 float vectors
- Extracted `executeQueryFp64()` — performs FFI call with FP64 double vectors
- `query()` body reduced to ~15 lines calling the three helpers
- Refactored `queryFp64()`, `queryWithReranker()`, and `queryWithRerankerFp64()` to reuse helpers
- Eliminated duplicated FFI parameter setup and output field handling code
- Added `tests/test_query_decomposition.phpt` — 14 test cases covering all query paths

- **SMELL-017: Extracted `collection_batch_op()` template in `ffi/zvec_ffi.cc`** (#97)
- Replaced ~130 lines of duplicated code across `zvec_collection_insert_batch`,
`zvec_collection_upsert_batch`, and `zvec_collection_update_batch` with a shared
Expand Down
Loading
Loading