feat(smell-009): add queryWithReranker method, deprecate reranker on query#144
Merged
Conversation
…on query() - Add queryWithReranker() returning ZVecRerankedDoc[] for type-safe static analysis - Deprecate $reranker parameter on query() and queryFp64() with E_USER_DEPRECATED - query() now always returns ZVecDoc[] (clean path) — BC preserved via delegation - Update test_reranker_in_query.phpt to use new queryWithReranker() API - Add test_query_return_types.phpt covering return types and deprecation behavior - Update examples/query_with_reranker.php to use queryWithReranker() - Closes #90
s2x
changed the title
Review fix: queryFp64() with deprecated $reranker was delegating to queryWithReranker() (FP32 path) instead of queryWithRerankerFp64() (FP64 path).
The native zvec extension (ext) doesn't have queryWithReranker() yet. Tests using it must skip when loaded via the extension rather than FFI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.