refactor: Replace inheritance with ZVecQueryInterface for query types#143
Merged
Conversation
- Add ZVecQueryInterface with getHandle() and free() methods - ZVecVectorQuery implements ZVecQueryInterface, owns its destructor - ZVecGroupByVectorQuery implements ZVecQueryInterface independently (no extends) - Remove handleType branching from ZVecVectorQuery destructor - Each query type manages its own handle lifecycle via free() idempotency - All 132 tests pass Closes #93
s2x
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces inheritance-based design (
ZVecGroupByVectorQuery extends ZVecVectorQuery) with composition viaZVecQueryInterface.Closes #93
Changes
ZVecQueryInterfacewithgetHandle(): FFI\CDataandfree(): voidZVecVectorQueryimplementsZVecQueryInterface, owns its destructor with$closedflagZVecGroupByVectorQueryimplementsZVecQueryInterfaceindependently (noextends)$handleTypeproperty and branching destructor fromZVecVectorQueryfree()is idempotent (safe to call multiple times)Motivation
SMELL-012: The previous design had three problems:
ZVecGroupByVectorQueryinherited setter methods that called wrong FFI functions (zvec_vector_query_set_*on a group_by handle)$this->handleTypeviolating Open/Closed PrincipleTesting
tests/test_query_interface.phptverifies interface contract, independence of both types, idempotent free(), and functional queries