Use sqlalchemy's 'quote' function to quote table names and fix table quoting in cfr exporter

[seut]

See commits.

Closes #168.

[seut]

Moving back to draft as there seem to be issues.

[amotl]

Moving back to draft as there seem to be issues.

It might be totally unrelated, but it also might be related to unfortunate side-effects of shortcomings within the test suite, as only three test cases are failing. Let me bring in this patch first, and then have another look after rebasing.

• Dialect: Fix get_table_names() reflection method sqlalchemy-cratedb#10

[seut]

It might be totally unrelated, but it also might be related to unfortunate side-effects of shortcomings within the test suite, as only three test cases are failing. Let me bring in this patch first, and then have another look after rebasing.

* [Dialect: Fix `get_table_names()` reflection method sqlalchemy-cratedb#10](https://github.com/crate-workbench/sqlalchemy-cratedb/pull/10)

Yes I think it's unrelated. This PR should not have issues anymore now.

[codecov]

Codecov Report

Attention: Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 68.33%. Comparing base (6be34c3) to head (642b025).

Files	Patch %	Lines
cratedb_toolkit/util/database.py	78.57%	3 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main     #172       +/-   ##
===========================================
- Coverage   80.71%   68.33%   -12.38%     
===========================================
  Files          68       68               
  Lines        2712     2716        +4     
===========================================
- Hits         2189     1856      -333     
- Misses        523      860      +337     

Flag	Coverage Δ
influxdb	?
main	68.33% <81.25%> (+0.04%)	⬆️
mongodb	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[amotl]

Thank you!

[amotl]

What about this case and friends? a) Does it work? b) Does it deserve a dedicated test case?

assert database.quote_ident('"my_schema"."my_table"') == "my_schema.my_table"

[seut]

The current logic will not remove such valid quotes, why should it?

[amotl]

Unrelated to this patch specifically, but absolutely related to the same topic, see also that upcoming patch for the SQLAlchemy dialect implementation.

• Compiler: Add CrateIdentifierPreparer for properly quoting reserved words sqlalchemy-cratedb#21

We will be happy to have your voice on the relevant discussion, when applicable.

[seut]

I think we should rename the quote_ident function to quote_relation_name to express it's difference from DB's usual quote_ident functions.
As written at crate/sqlalchemy-cratedb#69 (comment), a quote or quote_identifier function is generally not able and intended to work on full-qualified (relation/column) names but only on the unqualified identifier part.

[seut]

@amotl
I've added a sanity check at the quoting function and also renamed it to express better what it does, pls check.