fix(streams): end iterators after closed shard exhaustion - #1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep the closed-shard Streams continuation change on a crabbuild-owned branch while upstream PR #372 is reviewed. This lets BeyondDB pin an immutable crabbuild fork commit without waiting for an official release.
StreamContinuation::MoreandEndto the shared storage contract.Proof
This branch and upstream PR ExtendDB#372 point at the same commit,
7eaa89b437feed0af0f05883d3f1493f86c6fc6d. SQLite and engine tests, cross-backend compile checks, strict Clippy, and format checks passed when the commit was authored. BeyondDB's signed process smoke exercises the contract through the DynamoDB SDK and AWS CLI across a hard restart.PostgreSQL and MongoDB runtime integration tests still need their database environments.