Fix website Rust example doctests - #40
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The website Rust example checker only linked
cellule-appandcellule-runtime, so examples importingcellule-typesfailed. The store guide also importscellule-store,bytes, andobject_storedirectly.Build the framework and store examples as separate Cargo groups, then pass each document the matching reported libraries. Keeping the store group separate preserves the feature-specific crate artifacts needed for compatible
bytes::Bytestypes.Validation
CARGO_TARGET_DIR=... python3 scripts/check-web-rust-examples.py— all 12 authored Rust example guides pass.git diff --checkThis fixes the failing base check for PR #38 after this change lands on
mainand its checks are rerun.