Repository navigation
Conversation
LLGo baseline benchmarks
Program measurements
Core language and compiler benchmarks
Compared with |
This reverts commit 1fcff48b9481b74ca2b5fcfbf6cf2678f4c96833.
This reverts commit 405a5d6998c4c07069b0d4a89999a08aacde3a7f.
cpunion
force-pushed
the
codex/windows-review-fixes-20260823
branch
from
August 24, 2026 02:29
cf155a4 to
730c1ea
Compare
cpunion
changed the base branch from
codex/windows-proposal-integration-20260818
to
main
August 24, 2026 02:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This draft is the complete native-Windows integration snapshot rebased onto
xgo-dev/llgomainatdaef162f1a64c460d0f3681c562f645612a388e8. It supersedes the closed #169 and is retained only as a validation/reference branch while the implementation is reconstructed into reviewable PRs. It is not intended to be merged as one PR.Related proposal: xgo-dev#2325.
The new PRs will use the final integrated behavior rather than blindly cherry-picking historical commits. In particular, commits that mix concerns or revise an earlier approach will not be picked whole. Each PR will be reconstructed from the smallest coherent final file/function/hunk set so that superseded implementations and unrelated changes do not leak across review boundaries.
Planned dependency order
SyscallN, FFI and callbacks, foreign-thread entry, faults, SEH/unwind, PC metadata, traceback, and profiling.goplus/libWindows CRT/WinSock and pthread/synchronization changes will be upstreamed as their own prerequisite PRs before this layer.Generic receiver-metadata and concurrent-output-parser fixes, if still needed, will be independent non-blocking PRs. Linux poller changes, macOS timing/xfail changes, generic
converthash, broad timing relaxations, and the old large-aggregate lowering are excluded from the Windows series unless independently justified and tested.Only the foundation prerequisite is advanced for review first. Later layers will not be submitted until their direct base has been reviewed and merged.
Rebase notes
mainand resolved the ESP download/file-lock and historical Plan 9 dependency overlaps.github.com/xgo-dev/plan9asm v0.5.0; no temporary plan9asm replacement remains.mainstatic-initialization contract and is not required by the first Windows milestone.cpunion/libandcpunion/llvmreplacements only in this integration snapshot. Reviewable LLGo PRs must consume upstreamed/released dependencies at the appropriate layer.Validation
go test ./internal/xtool/llvm ./internal/goarch ./internal/meta ./internal/crosscompile ./internal/cabi ./internal/buildgo test ./cl -run '^TestStaticGlobalInitSkipsLargeByteSlice$' -count=1go test ./cl -run '^TestRunAndTestFromTestrt/any$' -count=1 -timeout=3m -vgo test ./clexposed the stale large-aggregate interaction; after removing it, a 20-minute run reached only six LTO output mismatches caused by the local LLVM 19 warning that RISC-V+zcm/+zczare unrecognized. The targeted LTO command produces the same warnings and failures on a clean checkout of the exactmainbase commit, so they are not introduced by this branch.