chore: drop clang 11 support and update default version to 21#458
Conversation
Cpp-Linter Report
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughThis PR updates supported Clang version references: the self-test workflow's clang-version matrix drops version 11 (starting at 12), and action.yml's version input documentation removes 11 from accepted options and changes the default from '20' to '21'. ChangesClang Version Support Update
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This PR will resolve the CI failure from #457 since the latest version of clang-tools and clang-tools-static-binaries drops support for clang version 11 |
There was a problem hiding this comment.
Now that cpp-linter/clang-tools-static-binaries deploys a versions.json, the CI matrix could be automated
jobs:
pre-seed-versions:
runs-on: ubuntu-latest
outputs:
versions: ${{ steps.versions.outputs.versions }}
steps:
- id: versions
env:
# may not be needed because release assets are not rate limited
GITHUB_TOKEN: ${{ github.token }}
run: >-
gh release download
--repo cpp-linter/clang-tools-static-binaries
--pattern "versions.json" -O -
| python3 -c "import sys, json;
d = json.load(sys.stdin);
v = [x for x in d['llvm_versions']];
print(f'versions={json.dumps(v)}')"
>> $GITHUB_OUTPUT
test:
needs: [pre-seed-versions]
permissions:
contents: write
pull-requests: write
strategy:
matrix:
os: [ ubuntu-latest, macos-latest, windows-latest ]
clang-version: ${{ fromJson(needs.pre-seed-versions.outputs.versions) }}Maybe the doc strings too, but that would be trickier
|
Good point. Since there are still other place that need to be updated, I think explicitly displaying the version range here seems reasonable. |
Summary
This PR drops support for clang version 11 and updates the default clang version from 20 to 21.
Changes
action.yml— Removed11from the list of accepted version strings and updated the default from'20'to'21'..github/workflows/self-test.yml— Removed'11'from the clang-version test matrix.Motivation
Clang 11 is now several years old and is no longer actively maintained in the clang-tools-pip ecosystem. Clang 21 is the latest major version and should be the default going forward.
Summary by CodeRabbit