fix: add a file "shared drive" metadata to rules#4763
Merged
Conversation
taratatach
approved these changes
May 20, 2026
Comment on lines
+487
to
+491
| rule := s.FirstFilesRule() | ||
| if rule == nil || rule.Selector == couchdb.SelectorReferencedBy || len(rule.Values) == 0 { | ||
| return ErrDriveRootNotFound | ||
| } | ||
| rootID := rule.Values[0] |
Member
There was a problem hiding this comment.
Too bad we have to duplicate this code to get access to the rule :/.
I find rule.Values[0] not to be clear it represents the drive ID and was happy to see it used only in a helper.
But I don't have a better version to offer at the moment.
Comment on lines
+526
to
+529
| rootMime := "" | ||
| if file != nil { | ||
| rootMime = file.Mime | ||
| } |
Member
There was a problem hiding this comment.
nit: the declaration of rootMime could be moved with the declarations of rootType and rootName and the re-assignment of rootMime moved into the file block above.
shepilov
force-pushed
the
fix/file_share_drive_mime_type
branch
from
31c926b to
f689828
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
linagora/twake-drive#3850
Make rules[0].mime for file-root shared drives a derived value from the VFS file as far as UI use this field to check that the shared drive is a file and doesn't use specific field
Changes:
drive_root_typeto recipient shortcut target metadata.drive_root_typefrom the real VFS root instead of trusting legacy input.Assumptions